fix: recognize custom subtitle addons like Wizdom and Ktuvit (#80) - #127

Summary

Closes #80.

User-added Stremio subtitle addons like Wizdom and Ktuvit (the primary Hebrew subtitle providers for Israeli users) were installed successfully but were functionally inert — they showed up in Settings → Addons, could be enabled/disabled, but were never queried during playback. No Hebrew subtitles ever appeared in the player.

Root cause

Two sequential bugs:

1. StreamRepository.addCustomAddon at line 259 hardcoded type = AddonType.CUSTOM for every user-added addon, regardless of what resources the manifest declared. So a pure-subtitle addon (manifest resources: ["subtitles"]) ended up in the same bucket as a pure-stream addon (manifest resources: ["stream"]).

2. fetchSubtitlesForSelectedStream at line 1339 filtered strictly on type == AddonType.SUBTITLE, which only matched the built-in OpenSubtitles addon. Pure-subtitle addons stored as CUSTOM were never queried for subtitles.

The result: the addon was installed, the toggle worked, the stream resolver correctly ignored it (because getStreamAddons requires a stream resource in the manifest), but no code path ever actually fetched subtitles from it.

Fix

1. Classify addons by manifest resources at install time

addCustomAddon now inspects the parsed manifest's resources:

val resourceNames = addonManifest.resources.map { it.name }.toSet()
val hasSubtitles = "subtitles" in resourceNames
val hasStream = "stream" in resourceNames
val addonType = when {
    hasSubtitles && !hasStream -> AddonType.SUBTITLE
    else -> AddonType.CUSTOM
}

• Pure subtitle addon (Wizdom, Ktuvit) → SUBTITLE → picked up by the subtitle fetcher, ignored by the stream fetcher.
• Pure stream addon → CUSTOM with stream resource → picked up by the stream fetcher only (unchanged behavior).
• Hybrid addon (declares both stream and subtitles) → CUSTOM → picked up by the stream fetcher AND by the subtitle fetcher's new branch (see below).

2. Broaden the subtitle fetcher to include CUSTOM addons that declare subtitles

fetchSubtitlesForSelectedStream now also queries CUSTOM addons whose manifest has a subtitles resource:

val subtitleAddons = allAddons.filter { addon ->
    if (!addon.isInstalled || !addon.isEnabled) return@filter false
    if (addon.type == AddonType.SUBTITLE) return@filter true
    if (addon.type == AddonType.CUSTOM) {
        val declaresSubtitles = addon.manifest?.resources?.any { res ->
            res.name.equals("subtitles", ignoreCase = true)
        } == true
        return@filter declaresSubtitles
    }
    false
}

This covers two cases the type-classification fix alone doesn't:

• Users who installed Wizdom/Ktuvit before this fix landed — their DataStore still has the addon classified as CUSTOM. They benefit from change (2) immediately without needing to reinstall.
• Hybrid addons that legitimately provide both streams and subtitles — they should be queried for both resources.

Why the stream side is already correct

getStreamAddons at line 625 already skips AddonType.SUBTITLE, and at line 632-641 requires CUSTOM addons to declare a stream resource in the manifest. So newly-classified SUBTITLE addons are correctly excluded from stream fetches and won't pollute the stream picker with "no streams available" entries.

Test matrix

Risk

Low. Single file, 40-line change. The stream-side filter logic is untouched. The subtitle-side filter is a strict superset of the previous filter — no previously-queried addon will stop being queried. All new behavior is additive.

One very small edge case worth noting: the subtitle URL construction (buildSubtitlesUrl) has been working for OpenSubtitles for months and follows the standard Stremio protocol (/subtitles/{type}/{id}.json). Wizdom and Ktuvit follow the same protocol, so it should work out of the box, but if a specific provider turns out to need an unusual query format we can iterate in a follow-up PR.